dexter submitted this change.

View Change

Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved
smdp_Tests: remove custom_tls_cert module parameters

The module parameters mp_use_custom_tls_cert and mp_custom_tls_cert_path
are no longer needed, so let's remove them.

Change-Id: Ie37da6986410b663378531f4f0d50d95b3068964
Related: SYS#7339
---
M smdpp/smdpp_Tests.ttcn
1 file changed, 5 insertions(+), 10 deletions(-)

diff --git a/smdpp/smdpp_Tests.ttcn b/smdpp/smdpp_Tests.ttcn
index da4d054..17ed4e1 100644
--- a/smdpp/smdpp_Tests.ttcn
+++ b/smdpp/smdpp_Tests.ttcn
@@ -65,9 +65,6 @@
* mutual authentication. */
boolean mp_es2plus_use_mutual_tls := true;

- boolean mp_use_custom_tls_cert := true;
- charstring mp_custom_tls_cert_path := ""; // Empty means use cert pool only
-
/* Sets the server port of the ES9+ server (SM-DP+, NIST certificates) */
integer mp_es9plus_server_port_nist := 8000;

@@ -554,10 +551,12 @@
}

// Configure HTTP client
+ // The native rspclient cpp code (libcurl) recursively loads certs from the subdir (sgp26) and
+ // automatically uses self signed certificates as root certificate.
var integer result := ext_RSPClient_configureHttpClient(
g_rsp_client_handle_es9p,
- mp_use_custom_tls_cert,
- mp_custom_tls_cert_path
+ true, // enable the usage of use custom TLS certificates
+ "" // provede an empty certificate path, this means that the certificate pool is used.
);

if (result != 0) {
@@ -566,11 +565,7 @@
return false;
}

- if (mp_use_custom_tls_cert) {
- ext_logInfo("HTTP client configured - custom TLS: true");
- } else {
- ext_logInfo("HTTP client configured - custom TLS: false");
- }
+ ext_logInfo("HTTP client (ES9+) configured");

return true;
}

To view, visit change 41271. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie37da6986410b663378531f4f0d50d95b3068964
Gerrit-Change-Number: 41271
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: osmith <osmith@sysmocom.de>