Attention is currently required from: iedemam, neels, laforge.
1 comment:
Patchset:
First of all, my C compiler version (probably newer) fails to compile with this patch applied, it probably hints you in the error:
"""
/osmo-bsc/src/osmo-bsc/lchan_fsm.c:490:34: error: 'active_ms_rate_ctr' may be used uninitialized in this function [-Werror=maybe-uninitialized]
490 | lchan->active_ms = (struct osmo_time_cc){
| ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~
491 | .cfg = {
| ~~~~~~~~
492 | .gran_usec = 1*1000,
| ~~~~~~~~~~~~~~~~~~~~
493 | .forget_sum_usec = 1,
| ~~~~~~~~~~~~~~~~~~~~~
494 | .rate_ctr = active_ms_rate_ctr,
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
495 | .T_gran = -16,
| ~~~~~~~~~~~~~~
496 | .T_round_threshold = -17,
| ~~~~~~~~~~~~~~~~~~~~~~~~~
497 | .T_forget_sum = -18,
| ~~~~~~~~~~~~~~~~~~~~
498 | .T_defs = bts->network->T_defs,
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
499 | },
| ~~
500 | };
| ~
"""
If you want to run the tests locally:
$ make check
Then, you can see the output of the failing log under $buildir/tests/testsuite.dir/<number>/testsuite.log (or something like that, writing it by hard). Those are generated only for failing tests.
Since I think one of the VTY tests is failing too, you can run one of them for instance:
make -C tests/ vty-test VTY_TEST=power_ctrl.vty
And if you add U=u to the end, the vty file will be updated, you can use then git diff to see the difference with expected output.
To view, visit change 27081. To unsubscribe, or for help writing mail filters, visit settings.