pespin submitted this change.

View Change



1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Approvals: daniel: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified
xua_as_fsm: Remove TODO no longer valid

Routing Context is filled in in fill_notify_route_ctx().

Take the chance to move the logging a bit up in the function, to have
all npar filling together.

Change-Id: I57af18dacc0470d36ddd4705a9530bd44b31f9c0
---
M src/xua_as_fsm.c
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/xua_as_fsm.c b/src/xua_as_fsm.c
index bdcd0d5..422a2b4 100644
--- a/src/xua_as_fsm.c
+++ b/src/xua_as_fsm.c
@@ -128,6 +128,9 @@
if (!asp->fi || asp->fi->state == XUA_ASP_S_DOWN)
continue;

+ LOGPASP(asp, DLSS7, LOGL_INFO, "Tx NOTIFY Type %s:%s (%s)\n",
+ type_name, info_name, info_str);
+
/* Optional: ASP Identifier (if sent in ASP-UP) */
if (asp->remote_asp_id_present) {
npar->presence |= NOTIFY_PAR_P_ASP_ID;
@@ -135,11 +138,8 @@
} else
npar->presence &= ~NOTIFY_PAR_P_ASP_ID;

- /* TODO: Optional Routing Context */
-
- LOGPASP(asp, DLSS7, LOGL_INFO, "Tx NOTIFY Type %s:%s (%s)\n",
- type_name, info_name, info_str);
fill_notify_route_ctx(asp, npar);
+
msg = encode_notify(npar);
osmo_ss7_asp_send(asp, msg);
sent++;

To view, visit change 42114. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: merged
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I57af18dacc0470d36ddd4705a9530bd44b31f9c0
Gerrit-Change-Number: 42114
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>