pespin submitted this change.

View Change

Approvals: laforge: Looks good to me, approved daniel: Looks good to me, but someone else must approve Jenkins Builder: Verified
xua_rkm: remove unneeded check rkm_dyn_allocated

This is always true, as per checks done further above in the same
function.

Change-Id: I2977ddd4aa476172e61b76f7a6501f0af9d25062
---
M src/xua_rkm.c
1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/src/xua_rkm.c b/src/xua_rkm.c
index 44a0eb3..d88fda7 100644
--- a/src/xua_rkm.c
+++ b/src/xua_rkm.c
@@ -428,13 +428,10 @@
* we should refuse RKM DEREG if the ASP is still ACTIVE */
osmo_fsm_inst_dispatch(as->fi, XUA_ASPAS_ASP_DOWN_IND, asp);

- /* if we were dynamically allocated, release the associated
- * route and destroy the AS */
- if (as->rkm_dyn_allocated) {
- /* remove route + AS definition */
- ss7_route_destroy(rt);
- osmo_ss7_as_destroy(as);
- }
+ /* Release the associated route and destroy the dynamically allocated AS */
+ ss7_route_destroy(rt);
+ osmo_ss7_as_destroy(as);
+
/* report success */
msgb_append_dereg_res(resp, M3UA_RKM_DEREG_SUCCESS, rctx);


To view, visit change 41505. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: merged
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I2977ddd4aa476172e61b76f7a6501f0af9d25062
Gerrit-Change-Number: 41505
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>