Attention is currently required from: pespin.
4 comments:
Commit Message:
Patch Set #1, Line 11: timeouts, etc.
i'm having a hard time understanding this, clarify a bit?
is this an accurate explanation: "we discard paging requests when the paging queue is too long to deliver the request in time. T3113 defines this time." ?
How does it relate to `timer T3113` and `timer-dynamic T3113`
File src/osmo-bsc/net_init.c:
Patch Set #1, Line 78: PAGING_THRESHOLD_X3113_DEFAULT_SEC
AFAICT this is the only place where this #define is used. just put the number here, like for all the other X and T timers?
Patch Set #1, Line 80: "Drop new paging requests estimated to be scheduled too far in the future due to current queue length"},
as a user this leaves me curious and uninformed about how T3113 and X3113 relate. There is no limit on the length of VTY doc, it gets formatted nicely on telnet and adds valuable info to the vty reference pdf, so do explain elaborately
File src/osmo-bsc/paging.c:
Patch Set #1, Line 415: struct osmo_tdef *td_x3113 = osmo_tdef_get_entry(bts->network->T_defs, -3113);
the API intended way to do
td = osmo_tdef_get_entry(...);
OSMO_ASSERT(td);
use(td->val);
is
use(osmo_tdef_get(T_defs, -3113, OSMO_TDEF_S, -1));
The -1 gives you an implicit OSMO_ASSERT(), and the OSMO_TDEF_S still gives you the expected value in seconds even if we were to change the default to "1, OSMO_TDEF_M" = 1 minute in the T_defs.
Hmm, I'm just noticing that the assert part is not documented properly in the API doc of osmo_tdef_get(), I'll fix
To view, visit change 30345. To unsubscribe, or for help writing mail filters, visit settings.