Attention is currently required from: pespin.
View Change
1 comment:
Patchset:
Patch Set #1:
also, we have 13 instances of invoking sua_addr_parse without checking the return value, by far the majority of the calls. The function itself logs any error code paths. from what I can tell, I'd rather have a wrongly-routed message and that error log than a process crashing.
To view, visit change 40298. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I008ee6f9024247c14d986a2baba061cc12bf68ec
Gerrit-Change-Number: 40298
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-CC: laforge <laforge@osmocom.org>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Comment-Date: Thu, 15 May 2025 06:51:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No