fixeria submitted this change.

View Change


Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved
si2quater: bts_uarfcn_add(): check if already added first

This way we print the proper message if the given UARFCN is already
added, no matter if the UTRAN neighbour list is full or not.

Change-Id: Ife83023f6a9e28d77e44e4757457d4d1c879e78f
Related: SYS#6401
(cherry picked from commit a60d74ba9c660612833b2634435ce4f0714c7b34)
---
M src/osmo-bsc/system_information.c
1 file changed, 17 insertions(+), 3 deletions(-)

diff --git a/src/osmo-bsc/system_information.c b/src/osmo-bsc/system_information.c
index cfc9a04..7687c90 100644
--- a/src/osmo-bsc/system_information.c
+++ b/src/osmo-bsc/system_information.c
@@ -302,12 +302,12 @@
*ual = bts->si_common.data.uarfcn_list,
*scl = bts->si_common.data.scramble_list;

- if (len == MAX_EARFCN_LIST)
- return -ENOMEM;
-
if (pos >= 0)
return -EADDRINUSE;

+ if (len == MAX_EARFCN_LIST)
+ return -ENOMEM;
+
/* find the suitable position for arfcn if any */
pos = uarfcn_sc_pos(bts, arfcn, SC_BOUND);
i = (pos < 0) ? len : pos;

To view, visit change 32247. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: osmo-bsc
Gerrit-Branch: 2023q1
Gerrit-Change-Id: Ife83023f6a9e28d77e44e4757457d4d1c879e78f
Gerrit-Change-Number: 32247
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-MessageType: merged