Attention is currently required from: Hoernchen, laforge, pespin.

View Change

11 comments:

• File include/osmocom/gprs/gmm/gmm_pdu.h:

  • Patch Set #1, Line 16: tlv_definition

    You should include `<osmocom/gsm/tlv.h>` defining this struct.

  • Patch Set #1, Line 32: uint8_t sres[4],

    Why not a const pointer?

• File src/gmm/gmm_pdu.c:

  • Patch Set #1, Line 31: struct gprs_gmm_ms_net_cap {

    Run `struct_endianess.py`.

  • Patch Set #1, Line 142: 23

    `GSM_MAC_BLOCK_LEN`?

  • Patch Set #1, Line 147: rc = bitvec_unhex(&bv, "171933432b37159ef98879cba28c6621e72688b198879c00");

    Makes sense to add a TODO here, since you're hard-coding the payload.

  • Patch Set #1, Line 172: msgb_put_u8(msg, sizeof(ms_net_cap_def));

    Use `msgb_lv_put()`.

  • Patch Set #1, Line 274: GSM_MI_TYPE_TMSI

    `GSM_MI_TYPE_IMEI`!

  • Patch Set #1, Line 312: (void)imeisv_requested;

    What is this for?

• File src/gmm/gmm_prim.c:

  • Patch Set #1, Line 107: gmm_llc_down_cb_dummy

    `__func__`

  • Patch Set #1, Line 467: rc = gprs_gmm_prim_handle_unsupported(gmm_prim);

    This case can fall-through to default, but not critical.

  • Patch Set #1, Line 589: llc_prim

    Why would anybody pass you NULL pointer here? Just curious.

To view, visit change 32021. To unsubscribe, or for help writing mail filters, visit settings.