laforge submitted this change.

View Change

Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve
msc: f_tc_ho_inter_bsc0(): catch BSSMAP HandoverRequiredReject

It may happen that the target BSC is not yet connected to the MSC.
In this case the MSC rejects handover with HandoverRequiredReject.
Let's catch this PDU to make the verdict cleaner in such case.

Change-Id: I5ba98e323e0c7794554ccb115d7697ad03ccbfa5
Related: OS#6951
---
M msc/MSC_Tests.ttcn
1 file changed, 12 insertions(+), 5 deletions(-)

diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn
index 5464355..17fac68 100644
--- a/msc/MSC_Tests.ttcn
+++ b/msc/MSC_Tests.ttcn
@@ -6043,12 +6043,19 @@
/* Now the action goes on in f_tc_ho_inter_bsc1() */

/* MSC forwards the RR Handover Command to old BSS */
- var PDU_BSSAP ho_command;
- RAN_CONN.receive(tr_BSSMAP_HandoverCommand) -> value ho_command;
+ var PDU_BSSAP pdu_bssap;
+ alt {
+ [] RAN_CONN.receive(tr_BSSMAP_HandoverCommand) -> value pdu_bssap {
+ log("Rx HandoverCommand: ", pdu_bssap);
+ RAN_CONN.receive(tr_BSSMAP_HandoverSucceeded) -> value pdu_bssap;
+ log("Rx HandoverSucceeded: ", pdu_bssap);
+ }
+ [] RAN_CONN.receive(tr_BSSMAP_HandoverRequiredReject) -> value pdu_bssap {
+ setverdict(fail, "Rx HandoverRequiredReject: ", pdu_bssap);
+ Misc_Helpers.f_shutdown(__BFILE__, __LINE__);
+ }
+ }

- log("GOT HandoverCommand", ho_command);
-
- RAN_CONN.receive(tr_BSSMAP_HandoverSucceeded);

/* f_tc_ho_inter_bsc1() completes Handover, then expecting a Clear here. */
f_expect_clear();

To view, visit change 42106. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5ba98e323e0c7794554ccb115d7697ad03ccbfa5
Gerrit-Change-Number: 42106
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>