pespin submitted this change.

View Change

Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved
rtp: Avoid memcpy(len=0)

Change-Id: I7618c6509b67465d21271ea632bccc8cf11e4852
---
M src/rtp.c
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/rtp.c b/src/rtp.c
index 5c06c42..f4b0ada 100644
--- a/src/rtp.c
+++ b/src/rtp.c
@@ -199,7 +199,8 @@
rtph->timestamp = htonl(h->tx.timestamp);
h->tx.timestamp += duration;
rtph->ssrc = htonl(h->tx.ssrc);
- memcpy(msg->data + sizeof(struct rtp_hdr), data, payload_len);
+ if (payload_len > 0)
+ memcpy(msg->data + sizeof(struct rtp_hdr), data, payload_len);
msgb_put(msg, sizeof(struct rtp_hdr) + payload_len);

return msg;

To view, visit change 29044. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I7618c6509b67465d21271ea632bccc8cf11e4852
Gerrit-Change-Number: 29044
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-MessageType: merged