Attention is currently required from: daniel, fixeria, lynxis lazus, osmith, pespin.
1 comment:
File src/tcap.c:
So are you proposing then having the external symbol tcap_talloc_asn1_ctx (or whatever name) defined in libosmo-sigtran then?
yes, ideallt with an osmo prefix.
What happens then if a program linking to libosmo-sigtran also wants to use libosmo-asn1-tcap directly? defining the external symbol tcap_talloc_asn1_ctx again would probably fail?
Valid point. Seems like we have not yet encountered that with libasn1c, which uses that method. Seems like osmo-hnbgw, osmo-hnodeb, osmo-iuh, osmo-msc, osmo-remsim-{client,bankd,server} and osmo-sgsn seem to be the current users.
I guess if they are all defined as weak, it should work? Haven't tested it yet, though.
I'm not saying you must go that way, just saying "we've done it this way for that reason in libasn1c".
To view, visit change 42219. To unsubscribe, or for help writing mail filters, visit settings.