fixeria submitted this change.

View Change

Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified
db_auc: hexparse_stmt(): check value returned by osmo_hexparse()

Change-Id: I78bb3aff9dd57a38278bb34113ea764e0a54c439
Fixes: CID#272997
---
M src/db_auc.c
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/db_auc.c b/src/db_auc.c
index 975eb2d..11f282b 100644
--- a/src/db_auc.c
+++ b/src/db_auc.c
@@ -95,7 +95,10 @@
LOGAUC(imsi, LOGL_ERROR, "Error reading %s\n", col_name);
return -EIO;
}
- osmo_hexparse((void *)text, dst, dst_len);
+
+ if (osmo_hexparse((void *)text, dst, dst_len) != col_len)
+ return -EINVAL;
+
return 0;
}


To view, visit change 28424. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I78bb3aff9dd57a38278bb34113ea764e0a54c439
Gerrit-Change-Number: 28424
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-MessageType: merged