Attention is currently required from: fixeria.

View Change

1 comment:

• File src/tbf.h:

  • Patch Set #1, Line 260: state_fi

    Maybe move those internals to the private/protected part and only expose the *fi pointers?

    The priv/protected stuff will disappear eventually when we move code to C.
    In any case, the mainly used field is state_fsm.state_flags which I really need to know into cleaning because it's from old code and I may end up rewriting that.

     Anyways, not gonna block your patchset.

    Yes, it's really bikeshed, whether we want to call it "main", "general" or "state" or whatever. There's more interesting stuff to clean up in there.

    Also all this needs to be done iteratively with lots of steps, and I tend to spread burst of changes over time.
    It's quite usual that in osmo-pcu I started doing 1 change and I end up having 10 patches cleaning up /refactoring stuff before being able to actually touch the thing I want to touch in first place.

To view, visit change 30216. To unsubscribe, or for help writing mail filters, visit settings.