Attention is currently required from: falconia, laforge.
Patch set 3:Code-Review +1
View Change
1 comment:
File src/common/l1sap.c:
Patch Set #3, Line 1651: if (lchan->abis_ip.osmux.use)
not really critical but since you are already splitting the send_ul_rtp_packet() function, you could also split this into skip_ul_rtp_packet or similar. It's fine as it now too.
To view, visit change 32098. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ic0e2edf2ed90ba0ac6bee5e7d9629bf0255e256d
Gerrit-Change-Number: 32098
Gerrit-PatchSet: 3
Gerrit-Owner: falconia <falcon@freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-CC: laforge <laforge@osmocom.org>
Gerrit-Attention: falconia <falcon@freecalypso.org>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Comment-Date: Wed, 29 Mar 2023 09:23:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment