Attention is currently required from: jolly, pespin.
5 comments:
Commit Message:
Patch Set #2, Line 12: TCH/HS
TCH/AHS, not TCH/HS.
File src/osmo-bts-trx/sched_lchan_tchf.c:
Maybe say TCH/AFS rather than just AMR, for consistency.
Patch Set #2, Line 541: * - If the channel mode is AMR, transmit a dummy with speech
I'd document here the rationale about "FACCH displaces two speech frames rather than one".
This C module and function are for TCH/F only, hence the TCH/H-specific problem you are referring to does not apply here. We could keep doing dummy FACCH for all TCH/F modes, but the idea is to be consistent with what we do in TCH/H.
File src/osmo-bts-trx/sched_lchan_tchh.c:
Patch Set #2, Line 453: /* - If the channel mode is TCH/HS or TCH/EFS, transmit a dummy
The overall structure of the comment after your change no longer makes sense. Either cover both TCH/HS and TCH/AHS cases in one clause (with "CRC3 or CRC6" wording), or leave the non-AMR TCH/HS clause alone (like you did in TCH/F) and add a new clause for TCH/AHS as in TCH/H version of AMR.
Patch Set #2, Line 453: TCH/EFS
If we are keeping the whole comment structure as-is (see my other comment), this part should read TCH/AHS and not TCH/EFS.
To view, visit change 35132. To unsubscribe, or for help writing mail filters, visit settings.