Attention is currently required from: dexter.

Patch set 4:Code-Review -1

View Change

5 comments:

• File src/osmo-bsc/abis_rsl.c:

  • Patch Set #4, Line 1013: msgb_put_u32(msg, msg_id);

    Just curious, did you check if Ericsson expects this ERIC_MOBILE_ID to actually be the TLLI? Or it's really just some random ID liek our new msg_id?

• File src/osmo-bsc/pcu_sock.c:

  • Patch Set #2, Line 559: if (!pch->confirm)

    In the current implementation we always include RSL_IE_ERIC_MOBILE_ID when sending the IMMEDIATE ASS […]

    Cool :)

• File src/osmo-bsc/pcu_sock.c:

  • Patch Set #4, Line 557: } else {

    else is not generally useful after a break or return

    Please fix.

  • Patch Set #4, Line 558: if (pcu_rx_rr_paging_pch(bts, pag_grp, pch))

    code indent should use tabs where possible

    Please fix.

  • Patch Set #4, Line 561: return pcu_tx_pch_confirm(bts, pch->msg_id);

    why are you confirming it here? You should be confirming it when scheduling it / sending it to the BTS. That may be a while in the future due to the BTS paging queue being full.

To view, visit change 34192. To unsubscribe, or for help writing mail filters, visit settings.