Attention is currently required from: daniel, dexter, fixeria, pespin.

View Change

1 comment:

• File include/osmocom/netif/ipa.h:

  • Patch Set #3, Line 29: } __attribute__ ((packed));

    Can you try the unnamed struct version inside the macro which I mention? I'd prefer that one if that […]

    I've just uploaded a version using an anonymous union.

    However at this point, I do wonder if the benefit of readability doesn't favor the solution I initially suggested (simple array access).
    I do agree though that this is more elegant in that we don't use `long` objects to store single bytes.

To view, visit change 34445. To unsubscribe, or for help writing mail filters, visit settings.