Attention is currently required from: jolly.

6 comments:

File src/core/osmo_io_uring.c:
- Patch Set #7, Line 240: iofd->u.uring.read_msghdr = NULL;
  This one probably needs to be moved above around line 238?
- Patch Set #7, Line 216: goto submit_again;
  this goto can be implemented by simple recursive call:
```
    if (iofd->u.uring.read_len < g_io_uring_read_sqes)
        iofd_uring_submit_recv(iofd, action)
        
And then, I actually wonder why isn't this implemented as a proper C loop?
```
```
    while (iofd->u.uring.read_len < g_io_uring_read_sqes) { ... }
```
- Patch Set #7, Line 231: LOGP(DLIO, LOGL_DEBUG, "Read SQE completion, but msghdr not found, please fix!\n");
  sounds like LOGL_FATAL instead ;)
- Patch Set #7, Line 238:
  missing =NULL for last read_msghdr?
- Patch Set #7, Line 470: int idx;
  unsigned int
- Patch Set #7, Line 473: msghdr = iofd->u.uring.read_msghdr[idx];
  iofd->u.uring.read_msghdr[idx] = NULL;

To view, visit change 40494. To unsubscribe, or for help writing mail filters, visit settings.