laforge submitted this change.

View Change

Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve
rspro_server: use correct byte order in log message "Bankd IP/Port changed to <IP>:<Port>

The byte order is wrong and results in printing the IP as reverse.
"Bankd IP/Port changed to 1.0.0.127:9999".

Change-Id: I288ea70091d24fa95732f7035ab50100831be841
---
M src/server/rspro_server.c
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/server/rspro_server.c b/src/server/rspro_server.c
index a6fd421..2a382d8 100644
--- a/src/server/rspro_server.c
+++ b/src/server/rspro_server.c
@@ -331,7 +331,7 @@

/* determine if IP/port of bankd have changed */
if (conn->client.bankd.port != bankd_port || conn->client.bankd.ip != bankd_ip) {
- struct in_addr ia = { .s_addr = bankd_ip };
+ struct in_addr ia = { .s_addr = htonl(bankd_ip) };
LOGPFSML(conn->fi, LOGL_NOTICE, "Bankd IP/Port changed to %s:%u\n", inet_ntoa(ia), bankd_port);
conn->client.bankd.ip = bankd_ip;
conn->client.bankd.port = bankd_port;

To view, visit change 42502. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: merged
Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: I288ea70091d24fa95732f7035ab50100831be841
Gerrit-Change-Number: 42502
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis@fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>