Attention is currently required from: laforge.

View Change

3 comments:

• File pySim/commands.py:

  • Patch Set #2, Line 42: if cla >> 4 in [0x0, 0xA, 0x8]:

    I find this a bit difficult to read. Maybe cla & 0xF0 in [0x00, 0x0A, 0x80] is better. Also I am a bit lost here. The positions of the logical channel match ISO/IEC 7816, section 5.1.1 but 0xA0 and 0x80 are proprietary classes that are not encoded as per ISO/IEC 7816? Maybe a spec reference would help?

  • Patch Set #2, Line 93: if not cla:

    the caller must decide when to access the cache and when not?

  • Patch Set #2, Line 526: return self._tp.send_apdu_checksw(self.cla_byte + self.cla4lchan('e0') + '0000%02x%s' % (len(payload)//2, payload))

    Does this work? The class is E0 but E0 >> 4 is not in [0x0, 0xA, 0x8] (line 42)

To view, visit change 34846. To unsubscribe, or for help writing mail filters, visit settings.