neels has uploaded this change for review.

View Change

log: N-PCSTATE: use new value_strings

Related: SYS#6319
Change-Id: I7a13fcf2bfee232c6cebc3c1180b956a73abc24e
---
M src/osmo-bsc/osmo_bsc_sigtran.c
1 file changed, 21 insertions(+), 6 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/52/32152/1
diff --git a/src/osmo-bsc/osmo_bsc_sigtran.c b/src/osmo-bsc/osmo_bsc_sigtran.c
index 70dcdc5..553d1b7 100644
--- a/src/osmo-bsc/osmo_bsc_sigtran.c
+++ b/src/osmo-bsc/osmo_bsc_sigtran.c
@@ -208,8 +208,9 @@
bool connected;
bool disconnected;

- LOGP(DMSC, LOGL_DEBUG, "N-PCSTATE ind: affected_pc=%u sp_status=%d remote_sccp_status=%d\n",
- pcst->affected_pc, pcst->sp_status, pcst->remote_sccp_status);
+ LOGP(DMSC, LOGL_DEBUG, "N-PCSTATE ind: affected_pc=%u sp_status=%s remote_sccp_status=%s\n",
+ pcst->affected_pc, osmo_sccp_sp_status_name(pcst->sp_status),
+ osmo_sccp_rem_sccp_status_name(pcst->remote_sccp_status));

/* If we don't care about that point-code, ignore PCSTATE. */
msc = get_msc_by_pc(pcst->affected_pc);
@@ -254,14 +255,18 @@

if (disconnected && a_reset_conn_ready(msc)) {
LOGP(DMSC, LOGL_NOTICE,
- "(msc%d) now unreachable: N-PCSTATE ind: pc=%u sp_status=%d remote_sccp_status=%d\n",
- msc->nr, pcst->affected_pc, pcst->sp_status, pcst->remote_sccp_status);
+ "(msc%d) now unreachable: N-PCSTATE ind: pc=%u sp_status=%s remote_sccp_status=%s\n",
+ msc->nr, pcst->affected_pc,
+ osmo_sccp_sp_status_name(pcst->sp_status),
+ osmo_sccp_rem_sccp_status_name(pcst->remote_sccp_status));
/* A previously usable MSC has disconnected. Kick the BSSMAP back to DISC state. */
bssmap_reset_set_disconnected(msc->a.bssmap_reset);
} else if (connected && !a_reset_conn_ready(msc)) {
LOGP(DMSC, LOGL_NOTICE,
- "(msc%d) now available: N-PCSTATE ind: pc=%u sp_status=%d remote_sccp_status=%d\n",
- msc->nr, pcst->affected_pc, pcst->sp_status, pcst->remote_sccp_status);
+ "(msc%d) now available: N-PCSTATE ind: pc=%u sp_status=%s remote_sccp_status=%s\n",
+ msc->nr, pcst->affected_pc,
+ osmo_sccp_sp_status_name(pcst->sp_status),
+ osmo_sccp_rem_sccp_status_name(pcst->remote_sccp_status));
/* A previously unusable MSC has become reachable. Trigger immediate BSSMAP RESET -- we would resend a
* RESET either way, but we might as well do it now to speed up connecting. */
bssmap_reset_resend_reset(msc->a.bssmap_reset);

To view, visit change 32152. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I7a13fcf2bfee232c6cebc3c1180b956a73abc24e
Gerrit-Change-Number: 32152
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr@sysmocom.de>
Gerrit-MessageType: newchange