Attention is currently required from: lynxis lazus, matanp, neels.
View Change
1 comment:
Patchset:
Patch Set #1:
... it's worth saying that the current implementation calls paging_request_join_vsub, which comes from the MSC too.
I am pretty sure there are even more examples of the API mixup in the existing code. Yet, I believe we should not be making the situation even worse. As I said, I am not strictly against merging this, but let's see what the others think.
To view, visit change 41131. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: If23f8b0e42d4a3a8bf1c8f5ca81b045834b6cccd
Gerrit-Change-Number: 41131
Gerrit-PatchSet: 1
Gerrit-Owner: matanp <matan1008@gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu>
Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de>
Gerrit-CC: pespin <pespin@sysmocom.de>
Gerrit-Attention: neels <nhofmeyr@sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis@fe80.eu>
Gerrit-Attention: matanp <matan1008@gmail.com>
Gerrit-Comment-Date: Sat, 20 Sep 2025 13:01:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>
Comment-In-Reply-To: matanp <matan1008@gmail.com>