Attention is currently required from: fixeria, pespin.
8 comments:
File src/host/layer23/include/osmocom/bb/mobile/gsm48_rr.h:
Patch Set #5, Line 89: #define GSM48_RR_GST_OFF 0
can we have this as an enum?
Done
Patch Set #5, Line 220: /* group call */
Ack
Done
Patch Set #5, Line 222: int group_state; /* extension to RR state for group transmit/receive modes */
can we have this as an enum?
Done
Patch Set #5, Line 230: int uplink_tries; /* Counts number of tries to access the uplink. */
if it's a counter, do we need negative values (int)?
Done
File src/host/layer23/src/mobile/gsm48_rr.c:
Patch Set #5, Line 73: * GSM48_MM_EVENT_UPLINK_BUSY: Notify MM layer about uplink becoming busy.
I think you added these a few commits before. […]
Only GSM48_MM_EVENT_NOTIFICATION has been added before. These comments describe the new interface to the process implemented with this patch.
Patch Set #5, Line 134: static int gsm48_rr_render_ma(struct osmocom_ms *ms, struct gsm48_rr_cd *cd, uint16_t *ma, uint8_t *ma_len);
I bet some of this pointers can be const.
It is out of the scope of this patch. The functions are not changed, they are just defined here, because they are used in code above the implementation.
Patch Set #5, Line 414: if (rr->state == state && state != GSM48_RR_ST_IDLE) {
are you sure this is correct' this should be == iiuc, not !=.
It is allowed to change from IDLE to IDLE. The group sub-state may have changed, but the state itself.
we should start thinking about splitting this file into smaller pieces ;)
Maybe. This is one layer.
I changed the location of the new functions inside the gsm48_rr.c file. There is also a group now for all functions releated to uplink control. Also I split this patch into several smaller patches for easier review.
To view, visit change 34491. To unsubscribe, or for help writing mail filters, visit settings.