dexter submitted this change.

View Change

Approvals: Jenkins Builder: Verified dexter: Looks good to me, approved
pySim-shell: explain why we insist on a DF or ADF

Change-Id: I155cefb10864432d59a0a66410783b4c9772f8a4
---
M pySim-shell.py
1 file changed, 4 insertions(+), 0 deletions(-)

diff --git a/pySim-shell.py b/pySim-shell.py
index 06977f0..33c18fd 100755
--- a/pySim-shell.py
+++ b/pySim-shell.py
@@ -515,6 +515,10 @@
context['COUNT'] += 1
df = self._cmd.rs.selected_file

+ # The currently selected file (not the file we are going to export)
+ # must always be an ADF or DF. From this starting point we select
+ # the EF we want to export. To maintain consistency we will then
+ # select the current DF again (see comment below).
if not isinstance(df, CardDF):
raise RuntimeError(
"currently selected file %s is not a DF or ADF" % str(df))

To view, visit change 28158. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I155cefb10864432d59a0a66410783b4c9772f8a4
Gerrit-Change-Number: 28158
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier@sysmocom.de>
Gerrit-MessageType: merged