Attention is currently required from: neels, pespin.

Patch set 1:Code-Review +1

View Change

1 comment:

• File src/osmo-hnbgw/context_map.c:

  • Patch Set #1, Line 99: if (new_scu_conn_id < 0) {

    yes, and 64bit arch still have 32 bit int afair, so it will fail in most architectures :)

    At second review, I don't really understand your concern, pespin. osmo_sccp_instance_next_conn_id does return an int. So the local variable should be an int, like this patch does. The function either returns a positive integer 0x00000000 .. 0x00fffffe or it returns a negative value on error. The fact that the SCCP references are 24bit values means we never get anywhere near the 32bit MSB indicating negative values.

    So to summarize: I think this patch is correct as-is.

To view, visit change 33158. To unsubscribe, or for help writing mail filters, visit settings.