Hoernchen has uploaded this change for review.

View Change

ccid: generate proper error for short messages

Change-Id: I3bf0bebd361666a2f3d0341444415a6f25d2b4bf
---
M ccid_common/ccid_device.c
1 file changed, 3 insertions(+), 1 deletion(-)

git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/18/42318/1
diff --git a/ccid_common/ccid_device.c b/ccid_common/ccid_device.c
index 8a53860..7866d9f 100644
--- a/ccid_common/ccid_device.c
+++ b/ccid_common/ccid_device.c
@@ -836,8 +836,10 @@

short_msg:
LOGP(DCCID, LOGL_ERROR, "Short CCID message received: %s; ignoring\n", msgb_hexdump(msg));
+ resp = gen_err_resp(ch->bMessageType, ch->bSlot, get_icc_status(cs), ch->bSeq,
+ CCID_ERR_CMD_NOT_SUPPORTED);
msgb_free(msg);
- return -1;
+ return ccid_slot_send_unbusy(cs, resp);
}

/* Section 5.3.1 ABORT */

To view, visit change 42318. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newchange
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: I3bf0bebd361666a2f3d0341444415a6f25d2b4bf
Gerrit-Change-Number: 42318
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild@sysmocom.de>