neels has uploaded this change for review.

View Change

osmo-smdpp.py: enable --host and --port cmdline args (and document)

Change-Id: Ic98dac1e1e713d74c3f8052c5bbeb44445aa8ab4
---
M docs/osmo-smdpp.rst
M osmo-smdpp.py
2 files changed, 15 insertions(+), 5 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/25/39725/1
diff --git a/docs/osmo-smdpp.rst b/docs/osmo-smdpp.rst
index ab7cc82..0eab290 100644
--- a/docs/osmo-smdpp.rst
+++ b/docs/osmo-smdpp.rst
@@ -92,10 +92,20 @@
commandline options
~~~~~~~~~~~~~~~~~~~

-osmo-smdpp currently doesn't have any configuration file or command line options. You just run it,
-and it will bind its plain-HTTP ES9+ interface to local TCP port 8000.
+Typically, you just run it without any arguments, and it will bind its plain-HTTP ES9+ interface to
+`localhost` TCP port 8000.

+osmo-smdpp currently doesn't have any configuration file.

+There are command line options for binding:
+
+Bind the HTTP ES9+ to a port other than 8000::
+
+ ./osmo-smdpp.py -p 8001
+
+Bind the HTTP ES9+ to a different local interface::
+
+ ./osmo-smdpp.py -H 127.0.0.1

DNS setup for your LPA
~~~~~~~~~~~~~~~~~~~~~~
diff --git a/osmo-smdpp.py b/osmo-smdpp.py
index 351787e..9328b99 100755
--- a/osmo-smdpp.py
+++ b/osmo-smdpp.py
@@ -581,15 +581,15 @@

def main(argv):
parser = argparse.ArgumentParser()
- #parser.add_argument("-H", "--host", help="Host/IP to bind HTTP to", default="localhost")
- #parser.add_argument("-p", "--port", help="TCP port to bind HTTP to", default=8000)
+ parser.add_argument("-H", "--host", help="Host/IP to bind HTTP to", default="localhost")
+ parser.add_argument("-p", "--port", help="TCP port to bind HTTP to", default=8000)
#parser.add_argument("-v", "--verbose", help="increase output verbosity", action='count', default=0)

args = parser.parse_args()

hs = SmDppHttpServer(HOSTNAME, os.path.join(DATA_DIR, 'certs', 'CertificateIssuer'), use_brainpool=False)
#hs.app.run(endpoint_description="ssl:port=8000:dhParameters=dh_param_2048.pem")
- hs.app.run("localhost", 8000)
+ hs.app.run(args.host, args.port)

if __name__ == "__main__":
main(sys.argv)

To view, visit change 39725. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newchange
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ic98dac1e1e713d74c3f8052c5bbeb44445aa8ab4
Gerrit-Change-Number: 39725
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr@sysmocom.de>