Attention is currently required from: arehbein, laforge, pespin.

7 comments:

Patchset:
- Patch Set #11:
  I really still fail to see why do we want to have & use a new API which puts together prepending the […]
  I think it looks nicer with the helper, but I'd split up this commit into a part that changes the segmentation_cb and one that adds the send helpers.
File examples/ipa-stream-client.c:
- Patch Set #11, Line 109: if (osmo_ipa_process_msg(msg) < 0) {
  Remove this, it's now handled in the segmentation_cb
File examples/ipa-stream-server.c:
- Patch Set #11, Line 54: if (osmo_ipa_process_msg(msg) < 0) {
  Remove this, it's now handled in the segmentation_cb
- Patch Set #11, Line 60: osmo_ipa_stream_srv_send(conn, IPAC_PROTO_UNSPECIFIED, IPAC_PROTO_UNSPECIFIED, msg);
  Using the proto/proto_ext getters here is more clear imho than using IPAC_PROTO_UNSPECIFIED and dealing with it in osmo_ipa_stream_srv_send()
File src/ipa.c:
- Patch Set #11, Line 481:
```
if (ipaccess_proto == IPAC_PROTO_UNSPECIFIED) {
		ipaccess_proto = msg_get_ipa_proto(msg);
		pe = msg_get_ipa_proto_ext(msg);
	}
```
  I wouldn't special-case this here. Also I'm not sure where IPAC_PROTO_UNSPECIFIED is defined and what its value is.
File src/stream.c:
- Patch Set #11, Line 47: #include <osmocom/netif/ipa.h>
  Unneeded
- Patch Set #11, Line 612: if (res == 0) {
  Unrelated/Unneeded?

To view, visit change 33201. To unsubscribe, or for help writing mail filters, visit settings.