neels submitted this change.

View Change


Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified
hnbgw: drop dead code from MSC_UnitdataCallback

This RANAP RESET code...

a) is not used:
osmo-hnbgw has only recently started sending RANAP UnitData by its own initiative.
Until very recently, osmo-hnbgw has only responded to receiving a RESET, with an ACK.
It has never sent a RESET message to the peer, here titan.

b) makes no sense implementation wise:
RANAP RESET handling is actually implemented in RAN_EMulation.ttcnpp.

c) makes no sense protocol wise:
The UnitDataCallback happens when osmo-hnbgw sends a RANAP UnitData to
titan: if at all, the only logical response would be a RESET ACK
message, not a RESET message.

Change-Id: Ie7b9022e991b63b945c7ec6e5c9f7c4eb5da4d7e
---
M hnbgw/HNBGW_Tests.ttcn
1 file changed, 25 insertions(+), 1 deletion(-)

diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn
index f0b5cfe..f87b621 100644
--- a/hnbgw/HNBGW_Tests.ttcn
+++ b/hnbgw/HNBGW_Tests.ttcn
@@ -108,7 +108,7 @@

function MSC_UnitdataCallback(RANAP_PDU ranap) runs on RAN_Emulation_CT return template RANAP_PDU {
// TODO: Actually implement unitdata handling
- return ts_RANAP_Reset(ts_RanapCause_om_intervention, cs_domain);
+ return omit;
}

const RanOps MSC_RanOps := {

To view, visit change 33473. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie7b9022e991b63b945c7ec6e5c9f7c4eb5da4d7e
Gerrit-Change-Number: 33473
Gerrit-PatchSet: 5
Gerrit-Owner: neels <nhofmeyr@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de>
Gerrit-CC: pespin <pespin@sysmocom.de>
Gerrit-MessageType: merged