Attention is currently required from: fixeria, pespin, dexter.
Patch set 5:Code-Review -1
View Change
1 comment:
File src/bts.cpp:
Patch Set #5, Line 1105: #ifdef ENABLE_ERICSSON_RBS
Agreeing with Pau here, maybe make the BTS type configurable somehow? Or even better: make BSC/BTS i […]
indeed, it is not at all an option to have a compile-time distinction. User installs an osmo-pcu packge and may run that with osmo-bts-trx or with osmo-bsc/ericsson-bts. We don't know at build time.
To view, visit change 31145. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I2a78651593323e8b9627c39918d949a33497b70f
Gerrit-Change-Number: 31145
Gerrit-PatchSet: 5
Gerrit-Owner: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Attention: dexter <pmaier@sysmocom.de>
Gerrit-Comment-Date: Mon, 06 Feb 2023 12:03:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Gerrit-MessageType: comment