Attention is currently required from: pespin.
4 comments:
Patchset:
I think with this you are only sorting out one of the concurrency problems when using rate_ctr/stats […]
How the caller chooses to use this remains very specialized for an application,
the main aim is to allow a hook to mutex around the stats reporting.
The way this is used in my hnbgw patch:
The main thread simply also holds a osmo_stats_report_lock() while groups are added/removed.
Because the counter-retrieving thread acquires osmo_stats_report_lock() when updating counters, things are guarded.
File src/core/stats.c:
Patch Set #1, Line 808: pthread_mutex_destroy(g_report_lock);
What happens if a pthread_mutex is destroyed while used? […]
good point
Patch Set #1, Line 819: void osmo_stats_report_lock(bool lock)
I'd definetly have 2 APIs here, one for lock and one for unlock. […]
easier to trace: good point
Patch Set #1, Line 831: pthread_mutex_t *lock = g_report_lock;
what's the point of this local variable?
brevity;
but in fact looks like leftovers from evolution of the patch, thx
To view, visit change 36538. To unsubscribe, or for help writing mail filters, visit settings.