Attention is currently required from: lynxis lazus, pespin.

View Change

3 comments:

• File osmo-epdg-master/Dockerfile:

  • Patch Set #3, Line 14: USER build

    How about we use current master of libgtpnl-tools from git instead? since typically we want to ensure that current master of everything works nicely together, and so we could use/test newer features added to the libgtpnl tools (like binding to specific IP addresses what you proposed) without waiting for a new release.

    If you agree, two ways we could do it:

    • build it from source here
    • add the nightly repository here and install it from there. IMHO the "# Add osmocom latest repo, should we ever require packages from there" block from debian-bookworm-erlang can be removed, the only other container using this image is osmo_dia2gsup-master and it doesn't install packages from osmocom:latest (and if it did, I also think it would make more sense to use master/nightly)

• File ttcn3-epdg-test/osmo-epdg.sh:

  • Patch Set #3, Line 1: #!/bin/bash

    This script gets executed with /bin/sh in ttcn3-epdg-test/jenkins.sh, so I'd change it to #!/bin/sh here as well to avoid confusion.

  • Patch Set #3, Line 9: # gtp-link needs to be kept running in order for osmo-epdg to be able to set up PDP contexts...

    remove the unused/commented out lines with MYPID, and add the comment on top of the gtp-link line instead?

To view, visit change 35994. To unsubscribe, or for help writing mail filters, visit settings.