Attention is currently required from: neels, fixeria, dexter.

View Change

1 comment:

• File src/osmo-bsc/pcu_sock.c:

  • Patch Set #2, Line 941: bts = llist_entry(state->net->bts_list.next, struct gsm_bts, list);

    The PCU still has a limitation that it can only handle one BTS at a time. […]

    I agree adding multiple BTS support here is out of scope.

    But whatever we merge, it must be safe, and the user should be protected from running invalid configurations that are easy to detect.

    I don't see how this addresses my concern "we should make sure that the user can operate this only in a safe configuration. In the worst case, we could check if thre are more than one (ericsson) BTS configured in the BSC, and refuse to operate the PCU socket with an associated error message."

    So at least add that kind of check, IMHO.

To view, visit change 31497. To unsubscribe, or for help writing mail filters, visit settings.