View Change

6 comments:

• File src/iu_client.c:

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13099):

    Patch Set #1, Line 180: static void ue_conn_sccp_addr_add(uint32_t conn_id, const struct osmo_sccp_addr *calling_addr) {

    open brace '{' following function definitions go on the next line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13099):

    Patch Set #1, Line 189: static const struct osmo_sccp_addr *ue_conn_sccp_addr_find(uint32_t conn_id) {

    open brace '{' following function definitions go on the next line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13099):

    Patch Set #1, Line 192: if (entry->conn_id == conn_id) {

    braces {} are not necessary for single statement blocks

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13099):

    Patch Set #1, Line 199: static void ue_conn_sccp_addr_del(uint32_t conn_id) {

    open brace '{' following function definitions go on the next line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13099):

    Patch Set #1, Line 931: "N-DATA.ind for unknown conn_id (%u)\n", conn_id);

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13099):

    Patch Set #1, Line 931: "N-DATA.ind for unknown conn_id (%u)\n", conn_id);

    please, no space before tabs

To view, visit change 35354. To unsubscribe, or for help writing mail filters, visit settings.