pespin has uploaded this change for review.

View Change

asp: Document misisng Optional ASP Identifier in Tx ASPUP ACK

This will basically use the same code logic as ASPUP branch above, so
document it here so that it is added in both places at the same time.

Change-Id: I9d8fabd8dccea4d45d78c6934737bfea25385e4a
---
M src/xua_asp_fsm.c
1 file changed, 11 insertions(+), 0 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/07/40007/1

diff --git a/src/xua_asp_fsm.c b/src/xua_asp_fsm.c
index d1e8b24..65af441 100644
--- a/src/xua_asp_fsm.c
+++ b/src/xua_asp_fsm.c
@@ -231,6 +231,17 @@
 	case XUA_ASP_E_ASPSM_ASPUP_ACK:
 		/* RFC3868 Ch. 3.5.2 */
 		xua->hdr = XUA_HDR(SUA_MSGC_ASPSM, SUA_ASPSM_UP_ACK);
+		/* Optional: ASP ID */
+#if 0
+		/* TODO: RFC 4666 3.5.2:
+		 * "The optional ASP Identifier parameter is specifically useful for IPSP
+		 * communication.  In that case, the IPSP answering the ASP Up message
+		 * MAY include its own ASP Identifier value." */
+		if (ss7_asp_peer_requires_asp_id(asp)) { /* Maybe configure in VTY "asp" node? */
+			asp_id = /* get a unique id of asp within as, eg. the index in as->asps[] */;
+			xua_msg_add_u32(xua, SUA_IEI_ASP_ID, asp_id);
+		}
+#endif
 		/* Optional: Info String */
 		break;
 	case XUA_ASP_E_ASPSM_ASPDN:

To view, visit change 40007. To unsubscribe, or for help writing mail filters, visit settings.