Attention is currently required from: pespin, dexter.

View Change

1 comment:

• File src/osmo-hnbgw/ranap_rab_ass.c:

  • Patch Set #14, Line 198: int ranap_rab_ass_req_extract_inet_addr(struct osmo_sockaddr *addr, uint8_t *rab_id, RANAP_RANAP_PDU_t *ranap_pdu)

    Its actually two times at the moment for each messages at the moment. […]

    As I stated, the best would likely be to use ranap_message which is an overall container for the RANAP message and all of its contents.

    I would expect the ASN.1 decode is among the more expensive things that osmo-hnbgw does. However, performance is likely irrelevant in the kind of deployments we are looking at, where we have a few hundred hNB. Remember, it is control plane processing only.

    To me it's more a question of code maintainability and KISS, performance is not super-critical.

    We do have a relatively well-established way how to deal with ranap_message in the SGSN and MSC, so why should we deviate from this existing pattern here?

To view, visit change 26792. To unsubscribe, or for help writing mail filters, visit settings.