Attention is currently required from: dexter.

View Change

1 comment:

• File pySim/esim/http_json_api.py:

  • Patch Set #1, Line 339: -> (dict, str):

    This is not a valid type spec. for a tuple. It should be:

    ```suggestion
        def rewrite_url(self, data: dict, url: str) -> tuple[dict, str]:

    ```

    
    or `Tuple[dict, str]`, in case we care about EOL Python versions <3.9.

    It might be a good idea to do more type checking using pylint (or mypy) during the build verification for Python projects in Jenkins. It could be a separate job just posting comments and printing the resulting code quality score, but not failing the build (V-1).

    @osmith@sysmocom.de, @laforge@osmocom.org what do you think?

To view, visit change 42274. To unsubscribe, or for help writing mail filters, visit settings.