Attention is currently required from: dexter, laforge, neels.
View Change
1 comment:
File src/codec/ecu_fr.c:
Patch Set #5, Line 315: struct fr_ecu_state *fr = (struct fr_ecu_state *) st;
Here and in the function below is where you need container_of:
static inline struct fr_ecu_state *_osmo_ecu_state_get_fr(struct osmo_ecu_state *st) {
return (struct fr_ecu_state *)container_of(st, struct fr_ecu_state, ecu_state);
}
static int ecu_fr_frame_out(struct osmo_ecu_state *st, uint8_t *frame_out)
{
struct fr_ecu_state *fr = _osmo_ecu_state_get_fr(st);
....
To view, visit change 35212. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I28672856e8e8f47e04ffe09ee3e07b577108cdc7
Gerrit-Change-Number: 35212
Gerrit-PatchSet: 5
Gerrit-Owner: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-Attention: neels <nhofmeyr@sysmocom.de>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: dexter <pmaier@sysmocom.de>
Gerrit-Comment-Date: Thu, 14 Dec 2023 12:38:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment