Attention is currently required from: dexter, neels.

View Change

2 comments:

• File pySim/esim/saip/personalization.py:

  • Patch Set #5, Line 129: for pe in pes.get_pes_for_type('usim'):

    I am not 100% sure here, maybe our application does not even require this. […]

    youi are correct in that an EF.SMSP can separately exist for both ISIM and CSIM. The latter is currently not supported at all from our codebase, so I'm fine with that. For ISIM, it is potentially more intresting. In reality, I'd expect 99.9% of all IMS enabled eSIMs out there not to contain a separate EF.SMSP, at which point the UE falls back to ADF.USIM/EF.SMSP. If we had a requirement for different SMSP for USIM and ISIM (or multiple USIM and/or ISIM in the profile, which is permitted under the spec), the problem is: How would the user specify which of those he wants to set. As the entire ConfigurableParameter only exists once, we'd probably at least want to rename this to UsimSmspTpScAddr and add a similar IsimSmspTpScAddr, to cover the most common case.

  • Patch Set #5, Line 132: #print("SMSP (orig): %s" % f_smsp.body)

    Do you want to keep this commented out debug print? (there is another one below)

    I'll remove it in the next version, thanks.

To view, visit change 41735. To unsubscribe, or for help writing mail filters, visit settings.