osmith has uploaded this change for review.

View Change

bssap: make "not implemented" log msgs consistent

Use LOGL_ERROR and word them the same way as the not implemented
message in sccp_sap_up_cn and sccp_sap_up_ran.

Related: SYS#5560
Change-Id: Ice8d67a30064a91d68256f43dcfb052d237e5594
---
M src/osmo-bsc-nat/bssap.c
1 file changed, 3 insertions(+), 3 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/osmo-bsc-nat refs/changes/01/27701/1

diff --git a/src/osmo-bsc-nat/bssap.c b/src/osmo-bsc-nat/bssap.c
index f88bb20..a7f629e 100644
--- a/src/osmo-bsc-nat/bssap.c
+++ b/src/osmo-bsc-nat/bssap.c
@@ -63,7 +63,7 @@
 		ret = bssap_cn_handle_reset_ack(addr, msg, length);
 		break;
 	default:
-		LOGP(DMAIN, LOGL_NOTICE, "Unimplemented BSSMAP UDT %s\n", gsm0808_bssap_name(msg->l3h[0]));
+		LOGP(DMAIN, LOGL_ERROR, "%s(%s) is not implemented!\n", __func__, gsm0808_bssap_name(msg->l3h[0]));
 		break;
 	}
 
@@ -96,7 +96,7 @@
 		ret = bssap_ran_handle_reset(addr, msg, length);
 		break;
 	default:
-		LOGP(DMAIN, LOGL_NOTICE, "Unimplemented BSSMAP UDT %s\n", gsm0808_bssap_name(msg->l3h[0]));
+		LOGP(DMAIN, LOGL_ERROR, "%s(%s) is not implemented!\n", __func__, gsm0808_bssap_name(msg->l3h[0]));
 		break;
 	}
 
@@ -143,7 +143,7 @@
 		rc = bssap_rcvmsg_udt(sccp_inst, addr, msgb, length - sizeof(*bs));
 		break;
 	default:
-		LOGP(DMAIN, LOGL_NOTICE, "Unimplemented msg type: %s\n", gsm0808_bssap_name(bs->type));
+		LOGP(DMAIN, LOGL_ERROR, "%s(%s) is not implemented!\n", __func__, gsm0808_bssap_name(bs->type));
 	}
 
 	return rc;

To view, visit change 27701. To unsubscribe, or for help writing mail filters, visit settings.