Attention is currently required from: neels, pespin.

View Change

1 comment:

• File src/osmo-hnbgw/hnbgw_cn.c:

  • Patch Set #3, Line 515: LOG_CNLINK(cnlink, DCN, LOGL_NOTICE, "using: cs7-%u %s <-> %s %s %s\n",

    Some context: this is the single "i am ready" notification for one SCCP link to an MSC or SGSN. […]

    multi-line logging is allways a PITA from the point of anyone trying to process log files. You cannot reasonably grep for context, if some part of a messge is printed int one line and some part of the same logical message is in another line. You'd have to grep for one of the messages and then get back with some other tool to see the remainder of the message.

    IMHO, we should avoid it at all costs. Yes, there are some historical cases where we do have multi-line logging, but I consider those as "we were young and stupid" rather than a good example.

    In order to work around the problem I added those LOGPC / DEBUGPC macros. Those worked fine back when all log targets were writing to stderr or to a file. They break unfortunately with syslog, systemd or gsmtap logging, so they are discouraged, too. Maybe we should actually OSMO_DEPRECATE them.

To view, visit change 33171. To unsubscribe, or for help writing mail filters, visit settings.