Attention is currently required from: jolly.

Patch set 1:Code-Review +1

View Change

1 comment:

• File src/ipa/main.c:

  • Patch Set #1, Line 264: case 'D':

    I wonder if it would make sense to accept a string like "00001111". A one byte hex number would also be ok.

    Somewhat unrelated, but helpful when fixed/improved:

    One thing that would be really helpful would be a converter that converts from ASCII hex digits to binary hex. This would solve a very annoying problem: The eIM generates an eIM configuration and outputs it as ASCII hex digits on the REST API. To use this output we have to convert it to binary using external tools to get the sample_eim_cfg.ber file you find in contrib. When we have a conveter, we could just use a text file with the ASCII hex string or even switch to a commandline parameter.

    After all, you could then use the converter here to set cfg.device_capabilities from a 2-hex-digit string (If you think this would make sense).

To view, visit change 43060. To unsubscribe, or for help writing mail filters, visit settings.