Attention is currently required from: laforge, pespin.

View Change

2 comments:

• File src/libmsc/sgs_iface.c:

  • Patch Set #1, Line 165: const uint8_t *mme_name_enc = TLVP_VAL_MINLEN(tp, SGSAP_IE_MME_NAME, SGS_MME_NAME_LEN);

    MME name is not some random DNS domain name, but a "fully qualified […]

    Done

• File src/libmsc/sgs_iface.c:

  • Patch Set #2, Line 178:

    I have a problem with alternate path: At the beginning of this function we require the contents of SGSAP_IE_MME_NAME to be at least SGS_MME_NAME_LEN bytes long. This is ensured by the if (!mme_name_enc) at the beginning. So there is no way around this.

    Now we want to allow also proprietary MME-name formats, but I wonder if the way we do it is effective as such a proprietary format might be anything. It might also be shorter than a normal MME-name and if this is the case, we won't reach this point.

    I just wanted to point this out. As it seems everything worked fine so far. Maybe those proprietary formats are all the same length as the specified MME name FQDN format. Something like "mme.osmocom.org" definitely wouldn't pass the length check above.

To view, visit change 43237. To unsubscribe, or for help writing mail filters, visit settings.