Attention is currently required from: osmith.

View Change

1 comment:

• File tests/test_construct.py:

  • Patch Set #2, Line 8: DnsAdapter,

    @laforge@osmocom. […]

    The usual approach in our code would be to simply have two (or more) lines starting with "from osmocom.construct import ...".
    See https://gitea.osmocom.org/osmocom/pyosmocom/src/commit/a5bc2a20f439f2ab309a38bfa6e2cf4266e9c11a/src/osmocom/construct.py#L14 for example, where we have three lines doing "from construct import ..."

    I often even group the imported symbols logically in such situations.

    I personally think one line per symbol is wasteful of my screen real-esetate.

    If there's a standard to do it differently, but then we should convert the entire codebase to that style, and not do it one way in one file and another way in another file. PEP8 doesn't seem to cover that situation, at least I couldn't find it in my reading of the "Imports" section.

To view, visit change 41384. To unsubscribe, or for help writing mail filters, visit settings.