fixeria submitted this change.

View Change

Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve
trx_toolkit/transceiver: Do not scan tx_queue twice on tx path

Noticed while moving forwarding out of tx_queue_lock in the previous patch.

Change-Id: I225c44c4cc327b6786efce96d1278c6ec68fbc25
---
M src/target/trx_toolkit/transceiver.py
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/target/trx_toolkit/transceiver.py b/src/target/trx_toolkit/transceiver.py
index 7297abf..2a638c5 100644
--- a/src/target/trx_toolkit/transceiver.py
+++ b/src/target/trx_toolkit/transceiver.py
@@ -310,6 +310,7 @@

drop = []
emit = []
+ wait = []

self._tx_queue_lock.acquire()

@@ -318,8 +319,10 @@
drop.append(msg)
elif msg.fn == fn:
emit.append(msg)
+ else:
+ wait.append(msg)

- self._tx_queue = [msg for msg in self._tx_queue if msg.fn > fn]
+ self._tx_queue = wait
self._tx_queue_lock.release()

for msg in emit:

To view, visit change 39534. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: merged
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I225c44c4cc327b6786efce96d1278c6ec68fbc25
Gerrit-Change-Number: 39534
Gerrit-PatchSet: 1
Gerrit-Owner: kirr <kirr@nexedi.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-CC: lynxis lazus <lynxis@fe80.eu>
Gerrit-CC: osmith <osmith@sysmocom.de>