Attention is currently required from: jolly, pespin.
6 comments:
Patchset:
I also don't like the timer. […]
SI10 is actually not needed for the call establishment, it's needed for quicker cell change. Without SI10 a phone participating a group call would need to first tune to BCCH of each neighbor to see if the current group call is also ongoing there or not -- this would cause a gap in the call.
IIUC, the payload of SI10 is expected to remain static as long as a) there are no neighbor list changes, b) no ongoing group calls being released, and c) no new group calls being established. Maybe we can trigger SI10 generation and sending if a), b), or c) happens?
File src/osmo-bsc/system_information.c:
Patch Set #2, Line 1420: struct gsm_subscriber_connection *conn
should be `const`
Patch Set #2, Line 1424: *n_bts, *l_bts
cosmetic: better declare these two separately, so they're not hidden behind the `s_bts` assignment. Wait, they're only used within the for-loop? Then they should be moved there.
unsigned int save_cur_bit;
struct gsm_subscriber_connection *c;
both vars can be moved to the scope of use (for-loop)
where this limit is coming from?
is there a macro? if not, at least add a comment?
Patch Set #2, Line 1499: /* Do spare padding. We cannot do it earlier, because encoding might corrupt it if differenctial cell info
the same "differential cell info" mentioned a few lines above I guess...
Indeed, SI10 employs so-called differential encoding: you encode all the info for the first BTS and then only those parameters that differ for the remaining BTSs.
To view, visit change 34626. To unsubscribe, or for help writing mail filters, visit settings.