Attention is currently required from: dexter.

View Change

4 comments:

• File include/osmo-bts/bts.h:

  • Patch Set #1, Line 68: prefers

    "Prefers" implies that it supports both but simply has a preference.
    I guess "supports" is a better fit here?

  • Patch Set #1, Line 72: BTS_INTERNAL_FLAG_SPEECH_H_V1_RFC5993

    I suggest to use slightly different, consistent naming here:

    • BTS_INTERNAL_FLAG_HR_FMT_ETSI_TS101318
    • BTS_INTERNAL_FLAG_HR_FMT_RFC5993

• File src/common/l1sap.c:

  • Patch Set #1, Line 1920: if (bts_internal_flag_get(lchan->ts->trx->bts, BTS_INTERNAL_FLAG_SPEECH_H_V1_RFC5993)

    I believe it should be clarified in a comment that the only difference between the two formats is basically presence of a header in front of the actual speech payload. The bit ordering is the same for both.

  • Patch Set #1, Line 1925: memcpy(msgb_put(msg, 1), "\x00", 1);

    msgb_put_u8(msg, 0x00)

To view, visit change 30523. To unsubscribe, or for help writing mail filters, visit settings.