Attention is currently required from: keith.
Patch set 2:Code-Review +2
2 comments:
File src/libmsc/transaction.c:
I'm guessing you mean 0x%04x, although I don't understand why. […]
If let's say callref is 1, then '0x%x' would render '0x1', '0x%04x' would render '0x00000001'. By using '0x%04x' you ensure consistent formatting, regardless of the callref value. Now I remember that callref always has some MSB octet set, e.g. 0x[80]000001, so even with '0x%x' it would always be '0xXXXXXXXX'...
Patch Set #1, Line 165: %sfor
Actually done intentionally, because osmo_hexdump() seems to add a space at the end. […]
Ack
To view, visit change 31131. To unsubscribe, or for help writing mail filters, visit settings.