pespin submitted this change.

View Change


Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved
aaa_diameter_swx_cb.erl: Fix undef handle_error/5

We are passing extra parameters, so this function also needs to be
adapted to the extra parameter, like handle_answer.

Change-Id: Id66b849f62a98c4ae69ccd4106bc04b51712c589
---
M src/aaa_diameter_swx_cb.erl
1 file changed, 19 insertions(+), 3 deletions(-)

diff --git a/src/aaa_diameter_swx_cb.erl b/src/aaa_diameter_swx_cb.erl
index 472f1d4..bf4a79e 100644
--- a/src/aaa_diameter_swx_cb.erl
+++ b/src/aaa_diameter_swx_cb.erl
@@ -9,7 +9,7 @@
%% diameter callbacks
-export([peer_up/3, peer_down/3, pick_peer/4, pick_peer/5, prepare_request/3, prepare_request/4,
prepare_retransmit/3, prepare_retransmit/4,
- handle_answer/4, handle_answer/5, handle_error/4, handle_request/3]).
+ handle_answer/4, handle_answer/5, handle_error/4, handle_error/5, handle_request/3]).

%% peer_up/3
peer_up(_SvcName, Peer, State) ->
@@ -88,10 +88,14 @@

%% handle_error/4
handle_error(Reason, Request, _SvcName, _Peer) when is_list(Request) ->
- lager:error("error: ~p~n", [Reason]),
+ lager:error("SWx error: ~p~n", [Reason]),
{error, Reason};
handle_error(Reason, _Request, _SvcName, _Peer) ->
- lager:error("error: ~p~n", [Reason]),
+ lager:error("SWx error: ~p~n", [Reason]),
+ {error, Reason}.
+%% handle_error/5
+handle_error(Reason, _Request, _SvcName, _Peer, ExtraPars) ->
+ lager:error("SWx error: ~p, ExtraPars: ~p~n", [Reason, ExtraPars]),
{error, Reason}.

%% handle_request/3

To view, visit change 36117. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: Id66b849f62a98c4ae69ccd4106bc04b51712c589
Gerrit-Change-Number: 36117
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-MessageType: merged