Attention is currently required from: Hoernchen, laforge, pespin.
Patch set 3:Code-Review -1
View Change
1 comment:
File configure.ac:
Patch Set #3, Line 511: if
@pespin@sysmocom.de is correct here: it's the if-statement that needs to be fixed.
```suggestion
if test x"$log_macros" == x"no"
```
In addition to that, I suggest to rename `ENABLE_LIBOSMOCORE_NO_LOGGING_DEFAULT` to `ENABLE_LOG_MACROS_DEFAULT` and assign `"yes"` by default.
To view, visit change 42203. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I809ab2f61e72428ba21061055296eb83d6d710ab
Gerrit-Change-Number: 42203
Gerrit-PatchSet: 3
Gerrit-Owner: Hoernchen <ewild@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-Attention: Hoernchen <ewild@sysmocom.de>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Comment-Date: Wed, 25 Feb 2026 16:55:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes